In the and anticipated Harry Potter series.
Hogwarts offers each professor the option for lodging and food. Without the need to allocate money for housing and living costs, Hogwarts professors presumably pocket almost all of their salary. Nevertheless, considering the professors who briefed the screen during the Harry Potter movies, there are some particularly wealthy candidates.
Minerva McGonagall
The daughter of a muggle minister and a witch, Minerva worked at the Ministry in the Department of Magical Law Enforcement for two years after graduating and before returning to Hogwarts as a Transfiguration professor. She not only assumed the post of Head of Gryffindor House but was also appointed to Deputy Heistress.
Given her prudent nature, McGonagall no doubt had earned herself a small fortune from working as a government official and returning to Hogwarts as a professor at an early age. She was able to live for almost 110 years without the cost of rent or food. And as the Head of a House and Deputy Heistress (eventually turned Heistress), she likely earned the second-highest annual salary at Hogwarts behind only Albus Dumbledore.
Gilderoy Lockhart
Though only a professor at Hogwarts for one year, Gilderoy Lockhart inarguably was one of the school's wealthiest professors. The five-time Witch Weekly Most Charming Smile recipient is also a best-selling author for his series on autobiographical books on magical and heroic exploits.
Other than possibly Harry at the start of the series and Viktor Krum, Lockhart is the biggest celebrity in the wizarding world. Despite being exposed as a fraud, he certainly amassed quite a stable income over the years from his best-selling texts. Likewise, his book tours and g events, like the one in The Chamber of Secrets, permitted him the opportunity to connect with his fan-base while also collecting money from sales and the appearance itself.
Dolores Umbridge
Umbridge began her work as an amoral Ministry of Magic official once she graduated from Hogwarts and climbed the ranks to become Senior Undersecretary to the Minister for Magic under Fudge's tenure. She also headed the Muggle-born Registration Commission under Pius Thicknesse once she left Hogwarts.
A known teacher's pet, Umbridge ascended through the Ministry to get what she wanted, which undoubtedly brought higher wages with each new position and title. After leaving her post as Senior Undersecretary to teach DADA at Hogwarts, she presumably earned a double salary for her spot at the school while also as High Inquisitor for a paranoid Cornelius Fudge (she was even Heistress for a brief moment!). And as Head for a crucial department during the Second Wizarding War, Umbridge was no doubt one of the highest-paid Ministry officials.
Filius Flitwick
Known for his adeptness in Charms, Filius Flitwick began his teaching career at Hogwarts before the First Wizarding War and continued to teach after The Prologue in Deathly Hallows Part 2. As Charms Master and Head of Ravenclaw, he was situated to earn quite a bit of money from the school.
Outside of teaching, Flitwick was known as a successful dueling champion in his youth. Combining his theoretical earnings as a competitive dueler with that which he made from his tenure of at least four decades and as Head of Ravenclaw, Flitwick did quite alright for himself, definitely having more money socked away in Gringotts than most other Hogwarts professors.
Alastor 'Mad-Eye' Moody
Considered to be the most well-known Auror of the time, Alastor 'Mad-Eye' Moody was the Defense Against the Dark Arts instructor for just one year (sort of). The pureblood son of two Aurors, he himself was active in his career from at least the First Wizarding War until his death in the Second, some 27 years later.
As the son of Aurors, Mad-Eye inherited the savings of two Ministry officials. Assuming Aurors are paid bonuses for the criminals they apprehend, no one has earned more from the Department of Magical Law Enforcement than Mad-Eye as rumors say he filled half the cells in Azkaban himself. Also, with the presumed jinx placed on the DADA teaching position by Lord Voldemort, Dumbledore likely incentivized a highly paranoid Mad-Eye with higher-than-normal wages.
Horace Slughorn
A tenured professor of Hogwarts for more than a few decades with an affinity for nice things and remarkable pupils, Horace Slughorn was the Head of Slytherin House as well as Potions Master before his initial retirement. He once again resumed those positions with Snape as Heaster and continued to hold those posts once Voldemort and the Death Eaters were quelled.
Working as long as he had at Hogwarts presumably provided him with a comfortable living, especially as Head of Potions and Slytherin, but he likely received quite a few benefits from his prized students that moved on to bigger and better things post-Hogwarts. While his "wealth" may not be strictly defined monetarily, with his relationships and willingness to exploit them, Slughorn no doubt houses many rare trinkets as well as his Galleons.
Severus Snape
ing the Hogwarts staff after the First Wizarding War, Snape was appointed Potions Master in his first year and held the position until he switched departments to his much-coveted Defense Against the Dark Arts post. As well as his teaching roles, Snape maintained his job as Head of Slytherin until he was appointed Heaster during Voldemort's control of the school.
Though a half-blood, the Prince family line was likely pure-blooded, meaning what remained of the wizarding family's bequest went straight to Snape. Of course, he earned more as Head of Slytherin than a mere professor would. And since both the Ministry and Hogwarts were under Death Eater control during his time as Heaster, he not only received a raise for his promotion, but also likely received more than the standard annual salary given the corruption known of Voldemort and his cronies.
Sybill Trelawney
In a rare true trance at an interview for the Divination post at Hogwarts, Trelawney spouted the prophecy that would define Harry's life through his teenage years. Dumbledore gave her the job and despite splitting half the classes with Firenze after her initial 15 years, she continued teaching well into The Prologue of the series.
As the great-great-granddaughter of an acclaimed Seer, Cassandra, Sybill definitely comes from generational wealth - the notoriety of her ancestor surely brought some fortune to her family, which served as a secure foundation for her assets that would only grow with her salary and lack of living costs from working at Hogwarts for multiple decades.
Albus Dumbledore
Clever and astute, Professor Dumbledore perhaps had the broadest umbrella for income. He was, of course, Heaster of Hogwarts for at least 26 years and a professor at the school since the 1910s; the Chief Warlock of the Wizengamot, the judicial arm of the Ministry; Supreme Mugwump of the International Confederation of Wizards; and a contributor to Transfiguration Today as well as the author to a notable paper on the 12 uses of dragon's blood.
With wizarding ancestry, Dumbledore came from familial inheritance before carving his own path into the world. Often times the person people would turn to in need, Dumbledore filled whatever role was asked of him and was presumably justly compensated for some of those deeds. Just take a look at the back of his chocolate frog card - he had money coming in from many different directions for long periods of time.
Armando Dippet
Though the exact timeline for Armando Dippet's succession to Heaster is unconfirmed, he likely assumed the position briefly after the death of Sirius' great-great-grandfather Phineas Nigellus Black. Dippet, who was roughly 288 years old once becoming Heaster, only makes one appearance in the flesh during a flashback in The Chamber of Secrets.
Being 288 years old, the odds are in his favor that he earned quite a bit of money over his life, and assuming he was savvy with his income, the majority of it was locked away in Gringotts. Likewise, as Heaster for possibly 45 years, Dippet was the highest-earning employee at Hogwarts for multiple decades.
